Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(t3-chat): init #1643

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Conversation

arithefirst
Copy link
Contributor

@arithefirst arithefirst commented Mar 6, 2025

🎉 Theme for T3 Chat 🎉

A soothing color scheme for T3 Chat

💬 Additional Comments 💬

One very important thing to know, codeblocks do not work properly, and likely will not be able to. This is what codeblocks look like (mocha mauve), and looking in the HTML, you can see that the website was built with a classless syntax highlighter (react-syntax-highlighter), and all of the colors for the codeblocks are inline styles.
image
image

I currently am not sure on how fixable this is, but if anyone can think of a way, that would be seriously awesome.

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the userstyles.yml file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.less - all the CSS for the userstyle, based on the template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

@arithefirst arithefirst requested a review from uncenter March 7, 2025 02:33
@arithefirst
Copy link
Contributor Author

arithefirst commented Mar 7, 2025

I assume changing the .css into .less and updating line 6 should be all, as it was all I could find when reading through the newer CONTRIBUTING.md, but please correct me if I am mistaken!

@uncenter
Copy link
Member

uncenter commented Mar 7, 2025

I assume changing the .css into .less and updating line 6 should be all, as it was all I could find when reading through the newer CONTRIBUTING.md, but please correct me if I am mistaken!

There are quite a few other changes that need to be made unfortunately 😅 I would suggest copying the middle section of styles that are for T3 Chat specifically, pasting in the template, and pasting back in the T3 Chat styles in the same spot of the template as usual.

@arithefirst
Copy link
Contributor Author

Thanks, will do so ASAP.

@arithefirst
Copy link
Contributor Author

That look good? Seems to pass all checks.

@arithefirst arithefirst requested a review from uncenter March 7, 2025 17:59
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2025-03-10 at 07 34 18

This X icon is unthemed.

CleanShot 2025-03-10 at 07 34 48

This logged out limit text is unthemed. Original CSS below for reference.

.text-yellow-200\/80 {
    color: hsla(53,98%,77%,.8);
}

CleanShot 2025-03-10 at 07 35 46

The color of icons in icon buttons on hover is unthemed.

CleanShot 2025-03-10 at 07 36 15

The background of some icon buttons on hover is unthemed.

@uncenter uncenter added the waiting on author Note for staff that a re-review is not yet required label Mar 10, 2025
@arithefirst
Copy link
Contributor Author

arithefirst commented Mar 10, 2025

Thank you for your feedback, I unfortunately have a few classes that don't let me on my laptop for my morning block in school today, but I'll be sure to fix these later today!

@arithefirst
Copy link
Contributor Author

This X icon is unthemed...
All of these issues should be resolved now.

@arithefirst arithefirst requested a review from uncenter March 10, 2025 14:20
@uncenter uncenter removed the waiting on author Note for staff that a re-review is not yet required label Mar 10, 2025
@uncenter uncenter marked this pull request as draft March 11, 2025 11:17
@uncenter
Copy link
Member

I'm going to mark this is a draft for now seeing as you are still finding improvements to make - feel free to give it some time, maybe a week, accumulate changes, and then mark as ready when you are ready for a second review :)

@arithefirst
Copy link
Contributor Author

Nah, I finished everything up last night I believe

@uncenter uncenter marked this pull request as ready for review March 11, 2025 11:26
@arithefirst
Copy link
Contributor Author

2025-03-11.07-30-12.mp4

Here's just a screen recording of me walking through the account page to help with review, in case there's something that might not show up for free/logged out users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants