-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option to use a pre-registered Runner #1115
Conversation
Hey @kayman-mk! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
We already have several options to configure the Runner registration. I used a new parameter to be able to remove all the old methods easily with v8.0.0 |
@woz5999 @lpsm-nuageit Can you please have a quick look here? Are there any better names for the new variable coming into your mind? |
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Still to do: update examples to new registration method, update docs and describe new registration method EDIT: done |
@kayman-mk I believe we can use the same config nomenclatures that gitlab runner uses in the helm chart version. But since we're in a different stream, I think the name |
This all looks reasonable to me |
🤖 I have created a release *beep* *boop* --- ## [7.6.0](7.5.0...7.6.0) (2024-05-01) ### Features * add option to use a pre-registered Runner ([#1115](#1115)) ([9153a3a](9153a3a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Are there any plans to support AWS Secret Manager as secret store for Gitlab tokens? |
The docs are still unclear to me (new to project) |
Description
GitLab announced then Next GitLab Runner Token Architecture. Runners have to be registered manually.
This PR adds a new import parameter
runner_gitlab.preregistered_runner_token_ssm_parameter_name
holding the name of a SSM parameter (type:SecuredString
). This parameter contains the GitLab Runner token obtained from GitLab. All other registration methods will still work, but have been marked as deprecated and will be removed with v8.0.0 end of the year.This also solves the problems with Runners removed from GitLab at shutdown, resulting in new Runners not able to start.
Closes #1074 and #1109
Verification