Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: underline that volume_iops works only if runner_worker_docker_machine_fleet.enabled = true #1198

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

kayman-mk
Copy link
Collaborator

Description

The runner_worker_docker_machine_instance.volume_iops does not work for the docker+machine driver, but works for the fleeting mode which can be enabled via runner_worker_docker_machine_fleet.enabled = true. We amend the comment to make that clear.

Closes #1179

@kayman-mk kayman-mk requested a review from npalm as a code owner October 21, 2024 12:34
Copy link
Contributor

Hey @kayman-mk! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.6s
✅ REPOSITORY checkov yes no 14.75s
✅ REPOSITORY dustilock yes no 0.17s
✅ REPOSITORY gitleaks yes no 1.17s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 12.54s
✅ REPOSITORY secretlint yes no 1.12s
✅ REPOSITORY syft yes no 0.52s
✅ REPOSITORY trivy-sbom yes no 0.14s
✅ REPOSITORY trufflehog yes no 3.43s
✅ SPELL cspell 2 0 2.8s
✅ TERRAFORM terraform-fmt 1 0 0 0.06s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@kayman-mk kayman-mk merged commit 19dd778 into main Oct 21, 2024
19 checks passed
@kayman-mk kayman-mk deleted the kayma/remove-volume-iops branch October 21, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

volume_iops doesn't work
1 participant