Remove deprecated resources #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kayman-mk also on my list to check asap |
npalm
approved these changes
Oct 24, 2021
There was a problem hiding this comment.
@kayman-mk thanks for taking the time to remove depcreated logic
|
🎉 This PR is included in version 4.36.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove all resources markes as deprecated (see #186)
Migrations required
aws_zonevariable. It's no longer in use. Delete it.runners_off_peak_*variables withrunners_machine_autoscaling.enable_forced_updatesvariable. Useenable_asg_recreationinstead.Verification
Deployed the new version of the module into our production environment and ran some build jobs. Worked fine.
Documentation
We use pre-commit to update the Terraform inputs and outputs in the documentation via terraform-docs. Ensure you have installed those components.