-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove manual registration of Gitlab Runner #388
base: main
Are you sure you want to change the base?
refactor!: remove manual registration of Gitlab Runner #388
Conversation
@kayman-mk need a bit more time for this PR. I am happy to drop this really old feature. |
On my list! |
@kayman-mk can you rebase this PR, will check this early next week. So I can release all breaking changes at once. |
…/terraform-aws-gitlab-runner into kayma/register-runner-manually
thx |
99195e5
to
9767603
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looks good to me, one small remark.
@npalm Everything fixed. |
@npalm What about this PR? |
Goinng to dig in. |
@kayman-mk, maybe we could also suggest users to use the GitLab Terraform Provider to obtain their registration token?
Way I'm using the module right now: This would not work however for instance runners since there is no API. Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/16319 |
Description
Removes the ability to register a Gitlab Runner manually (as described in #186) and pass the token into the module. This was done using
secure_parameter_store_runner_token_key
It's now recommended to let the Gitlab Runner fetch the registration token from Gitlab and store it into a SSM parameter automatically.
If you use the
secure_parameter_store_runner_token_key
in the past: This SSM parameter is destroyed for every runner agent and a new one is created which is managed by the module. This means that new runners will register with Gitlab again.Another way to get the token is the
gitlabhq/gitlab
provider. Check the data sourcesgitlab_group
andgitlab_project
. It does not work for instance runners as there is no data source available.Closes #186
Migrations required
Verification
Deployed the new version of the module into our production environment and ran some build jobs. Worked fine.
ToDo