Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test find_min_max_timestamps_from_intervals() #904

Closed
DanilYachmenev opened this issue May 2, 2024 · 0 comments · Fixed by #911
Closed

Unit test find_min_max_timestamps_from_intervals() #904

DanilYachmenev opened this issue May 2, 2024 · 0 comments · Fixed by #911
Assignees
Labels
Outsource Task for interns

Comments

@DanilYachmenev
Copy link
Collaborator

There is a find_min_max_timestamps_from_intervals() in dataflow/core/utils.py that is being used in HistoricalDataSource

We need to add unit tests to dataflow/core/test/test_utils.py.

Implement full coverage of the function but not too much.
I'd expect 5-7 small unit test methods that cover each if-else clause in the function body.

For in each method, try different value types - for this please understand Intervals value type beforehand (see)

See unit test doc to follow the code style

Assigning @samarth9008 to re-distribute
Could be a good 2nd task for those who already understand our approach to unit testing, here some thinking is required

FYI @gpsaggese @DanilYachmenev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Outsource Task for interns
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants