Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for dassert_strictly_increasing_index() #999

Open
samarth9008 opened this issue May 23, 2024 · 7 comments
Open

Add unit test for dassert_strictly_increasing_index() #999

samarth9008 opened this issue May 23, 2024 · 7 comments
Assignees

Comments

@samarth9008
Copy link
Collaborator

samarth9008 commented May 23, 2024

We want to add unit tests for dassert_strictly_increasing_index()

Function location - https://github.com/kaizen-ai/kaizenflow/blob/b3469cc93e71c221e9533bfafbaa2b8a519791da/helpers/hpandas.py#L183

Test different corner cases for each type of inputs

You can use unit tests for hpandas.dassert_increasing_index() as a reference

See unit test doc to follow the code style
Also highly recommend to read this doc before submitting 1st PR

FYI @gpsaggese @sonaalKant @DanilYachmenev

@samarth9008 samarth9008 self-assigned this May 23, 2024
@samarth9008
Copy link
Collaborator Author

@DanilYachmenev If possible can you refine the specs even more? Thank you!

@samarth9008
Copy link
Collaborator Author

@SrujanaKomaravolu Whats the update?

@SrujanaKomaravolu
Copy link

I am going through the documentation once again and working on it simultaneously.

@SrujanaKomaravolu
Copy link

@samarth9008 I need a bit more time to complete this as I'm going through all the documents again. It's taking longer than expected.

@samarth9008
Copy link
Collaborator Author

Pls create a PR by Wednesday EOD otherwise, we are not ready to move forward.

@SrujanaKomaravolu
Copy link

okay

@samarth9008 samarth9008 mentioned this issue Jun 6, 2024
11 tasks
@mayank922 mayank922 added PR_for_reviewers The PR needs to be reviewed by Team Leaders and removed PR_for_reviewers The PR needs to be reviewed by Team Leaders labels Jun 7, 2024
@mayank922
Copy link
Contributor

Hi @samarth9008

I have added the Unit test cases for the function and Created a Pull request for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants