-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test dassert_lt() #1098
Unit test dassert_lt() #1098
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good PR. Few nits.
f848956
to
52a454a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final nits.
Sorry if their are repeated corrections. I could make them better with second review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
A bit paranoid to cover also this basic assertion, but code is well done
Created this PR for Issue #1095.
Changes Made:
Testing:
Ran code through pylint and pytest.
@samarth9008 please let me know if you have any further suggestions