Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test dassert_lt() #1098

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Conversation

jayati1397
Copy link
Contributor

Created this PR for Issue #1095.

Changes Made:

  • Implemented unit tests for dassert_lt.

Testing:
Ran code through pylint and pytest.

  • Pylint Errors: Class name: currently follows the convention specified here.
OUTPUT from the added lines in the file
helpers/test/test_dbg.py:718:0: C0115: Missing class docstring (missing-class-docstring)
helpers/test/test_dbg.py:718:0: C0103: Class name "Test_dassert_lt" doesn't conform to PascalCase naming style (invalid-name)
  • Pytest: No errors.
OUTPUT:
collected 5 items                                                                                                                                       

helpers/test/test_dbg.py::Test_dassert_lt::test1 (0.00 s) PASSED   [ 20%]
helpers/test/test_dbg.py::Test_dassert_lt::test2 (0.00 s) PASSED  [ 40%]
helpers/test/test_dbg.py::Test_dassert_lt::test3 (0.00 s) PASSED  [ 60%]
helpers/test/test_dbg.py::Test_dassert_lt::test4 (0.00 s) PASSED  [ 80%]
helpers/test/test_dbg.py::Test_dassert_lt::test5 (0.00 s) PASSED  [100%]

@samarth9008 please let me know if you have any further suggestions

@jayati1397 jayati1397 requested a review from samarth9008 July 24, 2024 21:06
@jayati1397 jayati1397 marked this pull request as ready for review July 24, 2024 21:29
Copy link
Collaborator

@samarth9008 samarth9008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR. Few nits.

helpers/test/test_dbg.py Show resolved Hide resolved
helpers/test/test_dbg.py Outdated Show resolved Hide resolved
helpers/test/test_dbg.py Outdated Show resolved Hide resolved
helpers/test/test_dbg.py Outdated Show resolved Hide resolved
helpers/test/test_dbg.py Show resolved Hide resolved
helpers/test/test_dbg.py Outdated Show resolved Hide resolved
helpers/test/test_dbg.py Outdated Show resolved Hide resolved
helpers/test/test_dbg.py Outdated Show resolved Hide resolved
helpers/test/test_dbg.py Outdated Show resolved Hide resolved
helpers/test/test_dbg.py Outdated Show resolved Hide resolved
@jayati1397 jayati1397 requested a review from samarth9008 July 25, 2024 05:05
@jayati1397 jayati1397 force-pushed the KaizenTask1095_unit_test_dassert_lt branch from f848956 to 52a454a Compare July 25, 2024 13:17
Copy link
Collaborator

@samarth9008 samarth9008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final nits.

Sorry if their are repeated corrections. I could make them better with second review.

helpers/test/test_dbg.py Outdated Show resolved Hide resolved
helpers/test/test_dbg.py Outdated Show resolved Hide resolved
helpers/test/test_dbg.py Outdated Show resolved Hide resolved
helpers/test/test_dbg.py Outdated Show resolved Hide resolved
@jayati1397 jayati1397 requested a review from samarth9008 July 29, 2024 13:30
Copy link
Contributor

@gpsaggese gpsaggese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

A bit paranoid to cover also this basic assertion, but code is well done

@samarth9008 samarth9008 merged commit d98f784 into master Jul 31, 2024
1 check passed
@samarth9008 samarth9008 deleted the KaizenTask1095_unit_test_dassert_lt branch July 31, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants