Unit test for broker with multiple submit twap orders #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lets follow the process of naming the PR correctly as we did in the previous in the PRs. |
samarth9008
reviewed
Jul 30, 2024
jayati1397
changed the title
Sameep2808
reviewed
Jul 31, 2024
Sameep2808
reviewed
Jul 31, 2024
jayati1397
force-pushed
the
KaizenTask1103_test_broker_with_multiple_orders
branch
from
6ffc72b to
a042636
Compare
Sameep2808
requested changes
Jul 31, 2024
Sameep2808
requested changes
Jul 31, 2024
jayati1397
force-pushed
the
KaizenTask1103_test_broker_with_multiple_orders
branch
from
7965757 to
976acc1
Compare
jayati1397
force-pushed
the
KaizenTask1103_test_broker_with_multiple_orders
branch
from
25854d7 to
4854961
Compare
added 2 commits
August 1, 2024 00:49
jayati1397
force-pushed
the
KaizenTask1103_test_broker_with_multiple_orders
branch
from
cbbdde6 to
943655e
Compare
jayati1397
commented
Aug 1, 2024
gpsaggese
reviewed
Aug 1, 2024
...xchangeWithDynamicScheduler.test_submit_twap_orders_multiple_submission/tmp.final.actual.txt
Outdated
Show resolved
Hide resolved
...hangeWithDynamicScheduler.test_submit_twap_orders_multiple_submission/tmp.final.expected.txt
Outdated
Show resolved
Hide resolved
Sameep2808
reviewed
Aug 2, 2024
added 2 commits
August 2, 2024 18:49
jayati1397
force-pushed
the
KaizenTask1103_test_broker_with_multiple_orders
branch
from
4f7d6bd to
84319ee
Compare
Sameep2808
approved these changes
Aug 5, 2024
...thDynamicScheduler.test_submit_twap_orders_multiple_submission/output/actual_orders1.txt.tmp
Outdated
Show resolved
Hide resolved
…WithDynamicScheduler.test_submit_twap_orders_multiple_submission/output/actual_orders1.txt.tmp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the Issue #1103
This is the first draft to see if the solution is correct.
We are testing broker with two twap orders being submitted by just one instance of broker.
I didn't use test_submit_twap_orders as it creates one instance of broker inside the function and calls submit_twap_orders once
Ran pytest and it passes.
Ran the linter too.
@samarth9008 please check and let me if the solution seems correct