Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue-785 Draft code for unit tests of normalize function #982

Merged
merged 4 commits into from
May 14, 2024
Merged

Issue-785 Draft code for unit tests of normalize function #982

merged 4 commits into from
May 14, 2024

Conversation

aish-nidhi
Copy link
Collaborator

@aish-nidhi aish-nidhi commented May 13, 2024 •
edited
Loading

Issue- #785

Unit tests for normalize() function :-

  • Test with simple signal input data
  • Test with NaN value in the signal input data

@aish-nidhi aish-nidhi added the PR_for_reviewers The PR needs to be reviewed by Team Leaders label May 13, 2024
@aish-nidhi
Copy link
Collaborator Author

This is a draft PR.

@aish-nidhi
Copy link
Collaborator Author

Both tests are passing and linter has been run on file.

image

gpsaggese
gpsaggese reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@gpsaggese gpsaggese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DanilYachmenev
DanilYachmenev reviewed May 14, 2024
View reviewed changes
Copy link
Collaborator

@DanilYachmenev DanilYachmenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DanilYachmenev DanilYachmenev merged commit 4ae261d into master May 14, 2024
1 check passed
@DanilYachmenev DanilYachmenev deleted the KaizenTask785_Unit_test_normalize branch May 14, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpsaggese gpsaggese gpsaggese left review comments

@DanilYachmenev DanilYachmenev DanilYachmenev approved these changes

@samarth9008 samarth9008 Awaiting requested review from samarth9008

Assignees
No one assigned
Labels
PR_for_reviewers The PR needs to be reviewed by Team Leaders
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aish-nidhi @DanilYachmenev @gpsaggese