Bug fixes in verbosity and logfile #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, complexity was set just if `use_arch=true` or one of `sel` or `surv` parameters would use a pareto dominance criteria (because they are calculated only if strictly needed). If we want a logfile, but `use_arch=false` and no pareto dominance is calculated in `sel` or `surv`, then the logfile would have all zeros for complexity statistics. Now we make sure we calculate the stats if they are being reported to the user, regardless if is in archive, in verbosity, or in a logfile.
lacava
approved these changes
Nov 18, 2023
|
the memcpy error might have to do with gcc version used to compile. thanks for the bug fixes and log improvements!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the best CPP sources I've ever seen. It was easy to follow along with what the source code does!
I was playing around trying to implement Pareto Lexicase Selection and found small improvements regarding reporting the stats.
While these fixes don't change anything in the library, they improve the verbosity and logfile. This is useful for people using the package who are interested in obtaining stats from the evolution.
I also updated the documentation for
functionsand improved testing of the CPP implementation.Just to mention, I encountered an issue when trying to compile the CPP test suite with
undefined reference tomemcpy@GLIBC_2.14'`. Somehow, I managed to get it to work on my machine, but I've made several changes, and I'm not exactly sure what exactly fixed the problem. I'm going to open an issue to formalize it.