Do not publish spec files to rubygems #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Liboul Nice catch. |
|
Hi there, Is there any chance that we could get this released to rubygems? I'm also struggling with a large slug size which would be greatly reduced if specs were not included. |
|
@gee-forr Sorry it has taken so long to get to this. I wanted to fix the CI build error, but there is a strange Rails 6 problem only in the testing environment that I've not been able to solve yet. |
|
2.6.3 released |
This was referenced Mar 8, 2022
Please don't apologise - we all lead crazy lives. Thank you for handling this silly minor issue, it's very much appreciated! |
This was referenced Mar 9, 2022
This was referenced Jun 23, 2024
Merged
This was referenced Jul 1, 2024
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
What is this PR?
Making sure that the spec/ folder is not published to rubygems.
As RubyGems points out, the test_files option is ignored
Why?
The specs are no use to the end user, and they inflate the project size. Heroku's slug size cap is 500 MB, the specs of this gem account for 14.7 MB. This change is important for us, as the limit of 500 MB has been reached.
Currently 👇
After this PR: