Created ListDiff class to handle diffing of lists. #14
Conversation
Created ListDiff and ListNode classes. Started on custom list diffing functionality.
Finished list diffing against nodes and returning the result.
|
|
||
| protected function diffList($oldText, $newText) | ||
| { | ||
| $diff = new ListDiff($oldText, $newText, $this->encoding, $this->isolatedDiffTags, $this->groupDiffs); |
There was a problem hiding this comment.
The 4th argument here should actually be $this->specialCaseTags, not $this->isolatedDiffTags -- the same goes for the call to HtmlDiff on line 206, I missed that in the review :/
|
I've been encountering some errors testing with the demo, some of them would be fixed by the comments suggested but I think there may be some additional issues with how the nested placeholders are processed. Here is a Gist with "old text" and "new text" that I've been testing with, taken from a real example in cdpACCESS: https://gist.github.com/jschroed91/ed6a21856b86e5ea7ff1 While testing on the demo, I suggest updating line 6 in the demo/index.php file to be I made some updates locally to fix the issue when lists have attributes (like class), and landed on an issue that appears to be related to processing the nested placeholders: |
Next issue to be resolved: <li> content is not separated... all on one line. Fixes were in for this, but I screwed it up and had to revert backwards like 4 hours.
… the rest of the diffing functionality! Now need to finish the update so that these changes work with the rest of the script.
|
This is looking good to me, I'm going to run some tests on it locally for some specific use cases to see if we're covering some of the complex lists. Also, looks like Scrutinizer was acting up so I scheduled a new inspection on the branch and will be waiting on that. |
Created ListDiff class to handle diffing of lists.
Created ListDiff class to handle diffing of lists.