Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
After the warm welcome of my last pull request I got motivated to do some more digging around in the php-htmldiff source to optimize some views in our applications that feel sluggish because of the html differ.
I made some optimizations with pretty amazing results;
There is a performance test (--group performance in phpunit). Here are my results:
(CPU: Intel(R) Core(TM) i7-3630QM CPU @ 2.40GH);
testParagraphPerformance test PHP5.6 :
v0.1.2 -> 45.75 seconds (memory: 14.50 MB)
master -> 5.93 seconds (memory: 14.50 MB)
testParagraphPerformance test PHP7 :
v0.1.2 -> 7.38 seocnds (memory: 10.0MB)
master -> 1.73 seconds (memory: 10.0MB)
The standard unit tests also feel a little faster, but since those are small its hard to measure.