Update BoomFilter to avoid Cayley panicing #744
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cayley uses a DeletableBloomFilter for kv stores, which may cause a panic when loading a database due to an off-by-one error. In particular, you will see something like this (using the latest release binary):
This was fixed in commit tylertreat/BoomFilters@e4c39d4, so it's sufficient to update the dependency on BoomFilters to resolve this issue.
It feels a bit silly to update my name to CONTRIBUTORS and AUTHORS for such a small change, so I decided not to add it for now. But if you really want me to put my name in those, then I can of course do so.