Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo to microsite and Readme #147

Merged
merged 5 commits into from
Jan 8, 2020
Merged

Add logo to microsite and Readme #147

merged 5 commits into from
Jan 8, 2020

Conversation

LukaJCB
Copy link
Collaborator

@LukaJCB LukaJCB commented Dec 24, 2019

Many thanks to @Zelenya for providing the logo ❤️

@LukaJCB LukaJCB requested a review from cb372 December 24, 2019 15:42
@cb372
Copy link
Owner

cb372 commented Dec 24, 2019

Hey @LukaJCB, thanks for this. But the files need slightly different names and format because we are using the sbt-microsites light theme (which was introduced as the default theme in v1.0). See the docs here: https://47deg.github.io/sbt-microsites/docs/customize/

It looks like we need to get the logo as an svg. Would that be possible?

In the short term we could revert to the pattern theme? But I think light looks nicer so I'd like to use that in the long term.

@cb372
Copy link
Owner

cb372 commented Jan 7, 2020

I've updated the PR to use an SVG logo so it works with the sbt-microsites 'light' pattern.

It looks fine in Firefox:

Screenshot 2020-01-07 at 19 44 48

but really weird in Chrome:

Screenshot 2020-01-07 at 19 44 39

If I open just the SVG file in a Chrome tab, it renders fine.

Not sure what to do about this. I'll see if any of the 47deg design boffins can help.

@Zelenya
Copy link

Zelenya commented Jan 8, 2020

Maybe the svg itself is the issues. Maybe my Photoshop is misbehaving

@calvellido
Copy link
Contributor

calvellido commented Jan 8, 2020

Hi! This PR updates both SVGs into this branch:

#152

I'm not really sure what the problem was, but the fill property in those SVGs was misbehaving (they were also shown as a plain dark shape in my OS viewer).

@cb372
Copy link
Owner

cb372 commented Jan 8, 2020

Thank you @calvellido! I've tested locally and it looks fine now.

@cb372 cb372 merged commit 27c8800 into master Jan 8, 2020
@cb372 cb372 deleted the add-logo branch January 8, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants