New: major refactor, general cleanup #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbackas
changed the title
discord for testing
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request performs a major refactor and general cleanup by removing the dependency on the App instance from command execution, unifying environment variable access with getEnv, and updating configuration for workflows.
- Removed the App parameter from command execution functions and updated command manager accordingly.
- Consolidated Settings management using a global Settings object.
- Updated GitHub workflow permissions and refactored the app initialization logic.
Reviewed Changes
Copilot reviewed 27 out of 29 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/commandManager.ts | Removed App dependency and updated command registration logic. |
| src/interfaces/command.ts | Adjusted CommandV2 interface by removing redundant App parameters. |
| src/handlers.ts | Added handler functions for channel and thread deletions. |
| src/cron.ts | Introduced cron jobs using getEnv and simplified scheduling. |
| src/commands/* | Updated command signatures to remove the App parameter. |
| src/app.ts | Refactored application initialization and removed legacy code. |
| scripts/* and .github/workflows/* | Configured workflow permissions and added deployment steps. |
Files not reviewed (2)
- deno.jsonc: Language not supported
- import_map.json: Language not supported
Owner
Author
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.