Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use classNameBindings instead of writing into classNames #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use classNameBindings instead of writing into classNames #117

wants to merge 1 commit into from

Conversation

BrianSipple
Copy link
Collaborator

Partially closes #116

Directly muting classNames is slated to be disallowed in the next version of Ember, and thus the one instance where we were [doing this in our table-columns component] seems to be the culprit for our current CI failures (testing against ember-beta and ember-canary).

This PR updates the component so that instead of pushing into classNames inside of init, we just compute the columnType-dependent class as a classNameBinding.

@BrianSipple BrianSipple mentioned this pull request Jan 5, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to latest Ember and fix tests
2 participants
@BrianSipple @cball