-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instance#clean! - do not remove downloads #38
base: master
Are you sure you want to change the base?
Conversation
If I make this change to the gem installed for hyku, then clean does not remove download .jar, only the .md5 file, e.g.
|
We should have a consistent approach, and wait to merge this until we resolve https://github.com/cbeer/solr_wrapper/pull/104/files. |
Applied a similar approach to the current solr_wrapper PR, may be revised again when that PR resolves. |
end | ||
|
||
## | ||
# Clean up any files in the fcrepo instance dir | ||
def remove_instance_dir! | ||
FileUtils.remove_entry(config.instance_dir, true) if File.exists? config.instance_dir | ||
FileUtils.remove_entry(config.instance_dir, true) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, when FileUtils.remove_*
is called with the force: true
, it ignores any StdErr on failures. Hence, the File.exists?
checks are removed here.
Still waiting on https://github.com/cbeer/solr_wrapper/pull/104/files |
Fix #37