Skip to content

Commit

Permalink
Update dependency for Kubeclient::Config vulnerability
Browse files Browse the repository at this point in the history
See ManageIQ/kubeclient#554, I fixed an embarrasing vulnerability in Kubeclient::Config — it could wrongly set `VERIFY_NONE`, allowing man-in-the-middle attacks and stealing cluster credentials 😳 
And I see this repo does use `Kubeclient::Config.read`.

kubeclient generally obeys SemVer, so upgrading 4.6.z to 4.9.z should be safe.  OTOH if you think upgrading is tricky, let us know on that kubeclient issue, we can backport the fix!

@harshit-splunk @rockb1017 I see several of fluent-plugin-* gems depend on '~> 4.6.0', and more than one are maintained by Splunk — I'm not going to send PRs to them all, please spread the word.
  • Loading branch information
cben authored Mar 25, 2022
1 parent 84600bc commit 430e67f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fluent-plugin-kubernetes-metrics.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'test-unit', '~> 3.3.0'
spec.add_development_dependency 'webmock', '~> 3.5.1'
spec.add_runtime_dependency 'fluentd', '>= 1.9.1'
spec.add_runtime_dependency 'kubeclient', '~> 4.6.0'
spec.add_runtime_dependency 'kubeclient', '~> 4.9.3'
spec.add_runtime_dependency 'multi_json', '~> 1.14.1'
spec.add_runtime_dependency 'oj', '~> 3.10.2'
end

1 comment on commit 430e67f

@hvaghani221
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cben, thank you for the update. I will test it with v4.9.3 and update the plugin.

Please sign in to comment.