Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ValueParserFactory for MountOption #288

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dr-bonez
Copy link

@dr-bonez dr-bonez commented Jul 8, 2024

gated under the "clap" feature

@cberner
Copy link
Owner

cberner commented Jul 10, 2024

Hmm, I generally don't think fuser should dictate the format of command line arguments. Is there broad precedent for doing that in Rust crates?

@dr-bonez
Copy link
Author

In order to support mount -t <fstype> it needs to be able to parse mount options in that specific format. In this case, fuser isn't opinionated about anything, mount is.

@cberner
Copy link
Owner

cberner commented Jul 16, 2024

Ok ya, that's a good argument. Can you add a few tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants