Support of conversion to java.time classes #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaosfirebolt
commented
Feb 2, 2025
Chaosfirebolt
commented
- resolves issue Support for java.time.Date converter? #493
- unit tests
- supported - Instant, LocalDate, LocalDateTime, LocalTime, OffsetDateTime, OffsetTime, ZonedDateTime
- register converters in default factory
- resolves issue cbeust#493 - unit tests - supported - Instant, LocalDate, LocalDateTime, LocalTime, OffsetDateTime, OffsetTime, ZonedDateTime - register converters in default factory
mkarg
reviewed
Feb 2, 2025
| protected List<DateTimeFormatter> supportedFormats() { | ||
| return List.of( | ||
| DateTimeFormatter.ISO_LOCAL_DATE_TIME, | ||
| new DateTimeFormatterBuilder().appendPattern("dd-MM-yyyy").appendLiteral('T').append(DateTimeFormatter.ISO_LOCAL_TIME).toFormatter() |
There was a problem hiding this comment.
There was a problem hiding this comment.
Not really. ISO_DATE_TIME has the same date format as ISO_LOCAL_DATE_TIME - year-month-day, but it can handle offset and zone id, if they are present. The extra pattern I wrote has the date part in day-month-year format, which is also widely used as far as I know.
How would you like to handle that one? I would leave it as is, as it follows more strictly a local date time format (no offset/zone information), but I don't really insist on that.
There was a problem hiding this comment.
@mkarg What are your thoughts on my previous comment?
There was a problem hiding this comment.
I will share them as soon as I have the time to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.