Improve Type Safety: Migrate from Sequence to TypedDict #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordonkoehn
force-pushed
the
typing_parr
branch
from
38c6dc9 to
b85ea2f
Compare
|
For future reference - I like pydantic, yet it seemed needed here as we already validate parameters elsewhere. |
|
@DrYak Let's merge ? |
|
@DrYak, May I merge this one? This fix is long overdue; I did it immediately after the Lollipop parallelization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced risk of accidental parameter mixing for
lollipop.deconvolute._decolvolute_bootstrap().This PR shall prevent future bugs in this regard and ensure maintainability.