Add ci for coding style #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to work one must crete a file `./.env` that defines `GOOGLE_JAVA_FORMATTER_JAR` as environment variable pointing to the location of the google-java-formatter jar file. Example `./.env` ``` GOOGLE_JAVA_FORMATTER_JAR="/usr/local/Cellar/google-java-format/1.10.0/libexec/google-java-format.jar" ```
herrmanno
approved these changes
Jun 13, 2021
|
Just checked the result of the formatter GitHub action: |
Co-authored-by: github-actions[bot] <action@github.com>
|
@herrmanno looks good, I fixed the ci for Java 16. |
herrmanno
reviewed
Jun 13, 2021
bin/format.sh
Outdated
| @@ -14,6 +14,4 @@ java --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \ | |||
| retVal=$? | |||
| if [ $retVal -ne 0 ]; then | |||
| echo "[ERROR]: Some files needed formatting" | |||
| exit $retVal | |||
There was a problem hiding this comment.
Is this necessary for the Github Action? Otherwise, a non-zero return value may be useful when the format script is used as (pre-commit) git hook to prevent committing code that does not satisfy the format rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a github action for automating coding style fixes using google-java-format. The goal is to keep future pull requests clean and make them easier to review.