Use "preferred serialization" consistently. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draft-ietf-cbor-cde.md
Outdated
| @@ -121,7 +121,7 @@ types 0/1 in a seamless way. | |||
| {{Section 4.2.2 of RFC8949@-cbor}} recommends handling this transition the same | |||
| way as with the transition between different integer representation | |||
| lengths in the basic generic data model, i.e., by mandating the | |||
| Preferred Encoding ({{Section 3.4.3 of RFC8949@-cbor}}). | |||
| Preferred Serialization ({{Section 3.4.3 of RFC8949@-cbor}}). | |||
There was a problem hiding this comment.
Isn't this section 4.1 of 8949? I assumed preferred serialization is capitalized here because it is the title of the section.
There was a problem hiding this comment.
This was specifically about encoding of integers, 3.4.3:
The preferred serialization of an integer that can
be represented using major type 0 or 1 is to encode it this way
instead of as a bignum (which means that the empty string never
occurs in a bignum when using preferred serialization)
Fixed the case, added "for all integers".
| @@ -93,9 +93,9 @@ Requirements_ defined for CBOR in | |||
| {{Section 4.2.1 of RFC8949@-cbor}}. | |||
|
|
|||
| In many cases, CBOR provides more than one way to encode a data item, | |||
| but also provides a recommendation for a *Preferred Encoding*. | |||
| but also provides a recommendation for a *Preferred Serialization*. | |||
There was a problem hiding this comment.
I think I'd make this not capitalized.
There was a problem hiding this comment.
Sorry, emacs global substitute keeps the case; fixed this below.
Now mostly downcased.
laurencelundblade
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #8