AD review 1 #19
Merged
AD review 1 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* keep in references to IEEE 1588-2008 * make RFC 8575 a normative reference as it channels IEEE 1588-2008
Also: clarify that the CBOR Time Tag Parameters registry group is new.
henkbirkholz
approved these changes
Oct 4, 2023
| @@ -91,7 +90,7 @@ IXDTF = ' | |||
| ' ; extracted from [IXDTF]; update as needed! | |||
|
|
|||
|
|
|||
| Duration = #6.1001(etime-detailed) | |||
| Duration = #6.1002(etime-detailed) | |||
| @@ -83,15 +83,31 @@ normative: | |||
| date: 2006-03-01 | |||
| seriesinfo: | |||
| ISO: 80000-3 | |||
| RFC8575: ptp-yang | |||
Comment on lines
+88
to
+93
| target: https://standards.ieee.org/ieee/1588/4355/ | ||
| title: > | ||
| 1588-2008 — IEEE Standard for a Precision Clock | ||
| Synchronization Protocol for Networked Measurement and Control | ||
| Systems | ||
| IEEE Standard for a Precision Clock Synchronization Protocol for | ||
| Networked Measurement and Control Systems | ||
| seriesinfo: | ||
| IEEE: 1588-2008 |
Comment on lines
+99
to
+110
| IEEE1588-2019: | ||
| target: https://standards.ieee.org/ieee/1588/6825/ | ||
| title: > | ||
| IEEE Standard for a Precision Clock Synchronization Protocol for | ||
| Networked Measurement and Control Systems | ||
| seriesinfo: | ||
| IEEE: 1588-2019 | ||
| author: | ||
| org: IEEE | ||
| date: 2020-06 | ||
| ann: Often called PTP v2.1, as it has been designed so it can be | ||
| used in way that is fully backwards compatible to IEEE1588-2008. |
Comment on lines
+142
to
+153
| ISO8601-2019: | ||
| display: 'ISO8601-1:2019' | ||
| target: https://www.iso.org/standard/70907.html | ||
| title: > | ||
| Date and time — Representations for information interchange — | ||
| Part 1: Basic rules | ||
| author: | ||
| - org: International Organization for Standardization | ||
| abbrev: ISO | ||
| seriesinfo: | ||
| ISO: '8601-1:2019' | ||
| date: 2019-02 |
draft-ietf-cbor-time-tag.md
Outdated
Comment on lines
474
to
481
| Key -4 (ClockAccuracy) can be used to indicate the clock accuracy as | ||
| per {{RFC8575}} (which is based on Table 6 in Section 7.6.2.5 of | ||
| {{IEEE1588-2008}}; additional values have been defined in Table 5 in | ||
| Section 7.6.2.6 of {{IEEE1588-2019}}). | ||
| It is defined as a one-byte unsigned integer as that is the range defined there. | ||
| The range between 32 and 47 is a slightly distorted logarithmic scale from | ||
| 25 ns to 1 s (see {{formula-accuracy-enum}}); the number 254 is the | ||
| 25 ns to 1 s (extended to 23 to 47 for 1 ps to 1 s in {{IEEE1588-2019}}) | ||
| — see {{formula-accuracy-enum}}; the number 254 is the |
Comment on lines
+466
to
+468
| {{RFC8575}} (which is based on Table 5 in Section 7.6.2.4 of | ||
| {{IEEE1588-2008}}; this has updated language as Table 4 in Section 7.6.2.5 | ||
| of {{IEEE1588-2019}}). |
Comment on lines
+497
to
+498
| characteristic are defined in Section 7.6.3 of {{IEEE1588-2019}} and the | ||
| same section in {{IEEE1588-2008}}. |
| @@ -615,7 +649,7 @@ durations are structurally identical to time values. | |||
|
|
|||
|
|
|||
| ~~~ cddl | |||
| Duration = #6.1001(etime-detailed) | |||
| Duration = #6.1002(etime-detailed) | |||
Comment on lines
+807
to
+809
| | 1 | Base Time value as in CBOR Tag 1 | {{-cbor}} \[RFCthis] | | ||
| | 4 | Base Time value as in CBOR Tag 4 | {{-cbor}} \[RFCthis] | | ||
| | 5 | Base Time value as in CBOR Tag 5 | {{-cbor}} \[RFCthis] | |
chrysn
reviewed
Oct 4, 2023
draft-ietf-cbor-time-tag.md
Outdated
| Key -4 (ClockAccuracy) can be used to indicate the clock accuracy as | ||
| per {{RFC8575}} (which is based on Table 6 in Section 7.6.2.5 of | ||
| {{IEEE1588-2008}}; additional values have been defined in Table 5 in | ||
| Section 7.6.2.6 of {{IEEE1588-2019}}). | ||
| It is defined as a one-byte unsigned integer as that is the range defined there. | ||
| The range between 32 and 47 is a slightly distorted logarithmic scale from |
There was a problem hiding this comment.
With there being a specification for the range from 23 to 47, is there even a point in referencing the old scale that starts at 32?
There was a problem hiding this comment.
I think this is worth saying (in particular since RFC 8575 is based on -2008), but maybe just as a parenthesis to to the 2019 version presented as the full range.
(Not saying, together with the fact that 23 could look like a typo for 32, will create confusion.)
See commits below...
... as per discussion at CBOR interim meeting 2023-10-04, we do not want to create new registry groups for tag parameters unless they are for what could be called protocols of their own such as CWT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you, Francesca!