Skip to content

Commit

Permalink
Eliminate Mac Android Debug Engine shard
Browse files Browse the repository at this point in the history
At one point, this shard built the Android Vulkan binaries, but during
the migration to ci.yaml-based recipes, the gn and build steps for that
build were accidentally removed. As such, this shard no longer builds
anything.

This was detected when a buildroot roll triggered a clobber build which
caused the verify_exported.dart script to fail due to a missing 'out'
directory, which caused several of us to wonder why we were:
1. Checking that we strip release binaries on a debug bot, and
2. Why we're checking that we strip release binaries before we actually
   build anything at all.

It appears that we used to build android vulkan binaries, such as in
steps 14-16 of Build 11130:
* https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Android%20Debug%20Engine/11130/overview

We migrated to ci.yaml-based infra in this commit:
* https://flutter-review.googlesource.com/c/infra/+/15660

A no-op rebuild was triggered in commmit:
* flutter#27599

Which triggered the following buikld, Build 11131:
* https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Android%20Debug%20Engine/11131/overview

That build does not contain the gn or build steps for the Android Vulkan
binaries.

HOWEVER... we have no users actually using Android Vulkan binaries, so
rather than update the build to fix this, we delete the shard altogether
and save some CPU.

This will be followed by a patch that removes the --enable-vulkan flag
from gn and throughout our build.
  • Loading branch information
cbracken committed Aug 10, 2021
1 parent f88aea6 commit 047b007
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions .ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -185,15 +185,6 @@ targets:
timeout: 60
scheduler: luci

- name: Mac Android Debug Engine
recipe: engine
properties:
android_sdk_license: \n24333f8a63b6825ea9c5514f83c2829b004d1fee
android_sdk_preview_license: \n84831b9409646a918e30573bab4c9c91346d8abd
build_android_debug: "true"
timeout: 60
scheduler: luci

- name: Mac Host Engine
recipe: engine
properties:
Expand Down

0 comments on commit 047b007

Please sign in to comment.