use read_u16 and fix clippy warnings #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
read_u16
step forwrite
-s, which speeds up the small string case a little bit (see benchmarks below). It also replaces the 32-bit seed with the one from rustc, rather than using than using the last 32bits of the 64bit one.It also fixes all clippy warnings:
FireFox -> Firefox
(correct capitalisation)u32::from
andu64::from
instead ofas
casts for lossless conversions.Thanks for the crate and let me know if I haven't conformed to style guidelines or anything else!
Benchmarks