Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define ODataExpression for getting object with ODataV4QuerySegments #28

Merged

Conversation

mildronize
Copy link
Contributor

@mildronize mildronize commented Jan 10, 2024

From my proposal #27, I would like to submit the PR for improve the code,

Please review the code, any suggest are welcome,

I've attached the coverage test on my local machine
CleanShot 2567-01-10 at 12 16 40@2x

@cbrianball
Copy link
Owner

Hey, thanks for the PR! Apologies for not responding to the issue you filed a couple of days ago. I like the idea -- it makes sense to be able to build the expression without having any knowledge of a base path/URL.

Over the next couple of days I'll try to find time to pull this down locally and fully wrap my head around the changes and see if it makes sense as-is or if there needs to be some tweaks.

I'm currently in the process of implementing support for async iterables (e.g., for await ... of), but that shouldn't have any impact on your suggestion since you aren't providing any new ways of executing OData queries within the library itself (just a way for consumers to get the relevant OData query so that they can attach it to their own path/URL).

@cbrianball
Copy link
Owner

cbrianball commented Jan 11, 2024

I like what I see. Please run npm run lint:fix and push those changes. Also, can you update the readme.md file to briefly explain the new types and an example of how they can be used.

Thank you for your work!

Once your changes are merged in, it will motivate me to finish what I've been working on (which shouldn't take long), then I'll push a new version of the package.

@mildronize
Copy link
Contributor Author

mildronize commented Jan 11, 2024

Thank you so much for your suggestion; that is a great idea to run lint (which I had already forgotten). However, I've fixed it with lint and updated the README.md.

Feel free to suggest anything; somehow, I don't understand your intention in the code. I try to guess what you think behind it. If something and the naming convention don't meet your standards, please let me know.

I'm very excited to see the new package version, I'm cheer on your work!

@mildronize mildronize force-pushed the main.seperate.fetch-and-query-builder branch from 32e0695 to 58f490b Compare January 11, 2024 04:51
@cbrianball
Copy link
Owner

Thank you so much! I plan to push a new version of the package in the next 2 - 3 days.

@cbrianball cbrianball merged commit 47b4992 into cbrianball:main Jan 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants