-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define ODataExpression for getting object with ODataV4QuerySegments #28
Define ODataExpression for getting object with ODataV4QuerySegments #28
Conversation
Hey, thanks for the PR! Apologies for not responding to the issue you filed a couple of days ago. I like the idea -- it makes sense to be able to build the expression without having any knowledge of a base path/URL. Over the next couple of days I'll try to find time to pull this down locally and fully wrap my head around the changes and see if it makes sense as-is or if there needs to be some tweaks. I'm currently in the process of implementing support for async iterables (e.g., |
I like what I see. Please run Thank you for your work! Once your changes are merged in, it will motivate me to finish what I've been working on (which shouldn't take long), then I'll push a new version of the package. |
Thank you so much for your suggestion; that is a great idea to run lint (which I had already forgotten). However, I've fixed it with lint and updated the Feel free to suggest anything; somehow, I don't understand your intention in the code. I try to guess what you think behind it. If something and the naming convention don't meet your standards, please let me know. I'm very excited to see the new package version, I'm cheer on your work! |
32e0695
to
58f490b
Compare
Thank you so much! I plan to push a new version of the package in the next 2 - 3 days. |
From my proposal #27, I would like to submit the PR for improve the code,
Please review the code, any suggest are welcome,
I've attached the coverage test on my local machine