Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter_expression_after_dot_notation query #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CraftSpider
Copy link
Contributor

No clear consensus, and definitely an important difference to track I feel

@cburgmer
Copy link
Owner

cburgmer commented Feb 4, 2022

I think there's another piece hiding in your query: The filter expression here operators on an object, if I checked correctly. There is https://cburgmer.github.io/json-path-comparison/#filter_expression_on_object which shows no consensus exists for that case. So this could be the reason for no consensus existing here either.

For the PR: we have already added complex queries in the past, but IMHO there should be a clear benefit not captured by some of the other simpler queries.

I'm happy to be proven wrong though, that is that this is not covered by https://cburgmer.github.io/json-path-comparison/#filter_expression_on_object.

@CraftSpider
Copy link
Contributor Author

Rust's jsonpath_lib gives notably different results in this case - returning no items matching the query unless you add an intermediate [*]. The intended test here is not just how it behaves on objects, but what 'the current object' means after a dot operator on an object.

@CraftSpider
Copy link
Contributor Author

Basically, some implementations seem to differ in their behavior when a filter on an object is done after selection on an object, and I think that's worth evaluating.

@cburgmer
Copy link
Owner

cburgmer commented Feb 4, 2022

I'll have a fresh look on it when it's not the end of the day. I just realised that you packed a few things in there. I might dig up some of the other existing queries to show how this is different!

@CraftSpider
Copy link
Contributor Author

Fair! I can see how this query is fairly non-atomic, looking at it again. I'll see if I can explain the results as a combination or the more atomic existing queries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants