Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't accept constants for 'has value' operator, this is not helpful #64 #66

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Don't accept constants for 'has value' operator, this is not helpful #64 #66

merged 1 commit into from
Jun 30, 2020

Conversation

cburgmer
Copy link
Owner

No description provided.

@cburgmer cburgmer requested review from glyn and remorhaz June 25, 2020 20:30
@cburgmer cburgmer mentioned this pull request Jun 25, 2020
Open
glyn
glyn approved these changes Jun 30, 2020
View reviewed changes
Copy link
Collaborator

@glyn glyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

remorhaz
remorhaz approved these changes Jun 30, 2020
View reviewed changes
Copy link
Collaborator

@remorhaz remorhaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The true/false were discussed as special cases, but that can be changed later.

@cburgmer cburgmer merged commit 88fe67b into master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glyn glyn glyn approved these changes

@remorhaz remorhaz remorhaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cburgmer @glyn @remorhaz