Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix git-version-gen path
Problem description
Currently calling cmake on the source directory generates a file
include/p4est_config.h
withas reported in DLR-AMR/t8code#1294.
Proposed change
The reason for the described problem is that the variable
PROJECT_SOURCE_DIR
incmake/git.cmake
is used to search for thegit-version-gen
program that is used to get the version number. However,PROJECT_SOURCE_DIR
is an empty variable sinceproject
was not yet called. Since we want to pass the version number toproject
we can not change the call sequence. Therefore, I replacedPROJECT_SOURCE_DIR
byCMAKE_CURRENT_SOURCE_DIR
, which is the path to the current source directory.Remark: We do not need an analogous PR in libsc since libsc's
include/sc_config.h
is already set correctly.