Sync #14
Merged
Sync #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to test the Workflow by triggering a PR. Please ignore. Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Turns out this GitHub Action does not contain a v before its SemVer. Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
- Added .env.testing file to setup minimum testing configuration
- Added Node setup & caching - Added building of frontend assets - Changed .env.testing config
- Removed .env.testing since it conflicted with local setups - Added global environment config variables
- Removed caching of node_modules in favor of setup-node's builtin caching config - Replaced deprecated set-output method for getting composer cache directory
This is hardening the setup by preventing a leak to the logs. While at it, I also instruct npm to install from package-lock.json to avoid possible security incidents by pinning the dependencies. Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Otherwise GitHub isn't reading the secrets from its Vault. Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
I'm not completely sure whether I can reuse the artifact on a production environment. The first step is to separate a build from a test. Once this Workflow passes, I am going to refactor the tests workflow to pull the artifact stored by this workflow. Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Fingers crossed that this works. I'm not sure whether I need a running MySQL. Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
I might need a PAT (Personal Access Token) but let's try without one first. Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
I first need to upload the build artifact before I can download it. Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
This being YAML I'm trying to quote the previous workflow to ensure it matches. Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Trying stuff until it works. Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
I have no idea why it isn't running. Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Maybe this works. Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
m( Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Was this the missing piece? Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Instead the idea is to reuse it in tests and deployment. Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
This is to check where the artifact is extracted.
This should extract public/build into the working directory. I've also added the git checkout and PHP steps
Defer dependency update checks to a bot.
stevenobird
previously approved these changes
Sep 30, 2024
We're using npm and composer. Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
Dependabot insists on having an item per package-ecosystem. Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de>
stevenobird
approved these changes
Sep 30, 2024
Ryuno-Ki
added a commit
that referenced
this pull request
Sep 30, 2024
* docs: linkdrop I want to test the Workflow by triggering a PR. Please ignore. * fix: get release version right Turns out this GitHub Action does not contain a v before its SemVer. * Testing Environment - Added .env.testing file to setup minimum testing configuration * Testing workflow adjustments - Added Node setup & caching - Added building of frontend assets - Changed .env.testing config * Testing workflow adjustments - Removed .env.testing since it conflicted with local setups - Added global environment config variables * Added DB_DATABASE to global testing workflow environment * Node.js test workflow adjustments - Removed caching of node_modules in favor of setup-node's builtin caching config - Replaced deprecated set-output method for getting composer cache directory * refactor: use secrets This is hardening the setup by preventing a leak to the logs. While at it, I also instruct npm to install from package-lock.json to avoid possible security incidents by pinning the dependencies. * fix: set environment Otherwise GitHub isn't reading the secrets from its Vault. * feat: add Build Workflow I'm not completely sure whether I can reuse the artifact on a production environment. The first step is to separate a build from a test. Once this Workflow passes, I am going to refactor the tests workflow to pull the artifact stored by this workflow. * refactor: use build artifact Fingers crossed that this works. I'm not sure whether I need a running MySQL. * fix: download artifact from other workflow I might need a PAT (Personal Access Token) but let's try without one first. * fix: wait on build with testing I first need to upload the build artifact before I can download it. * fix: quote workflow This being YAML I'm trying to quote the previous workflow to ensure it matches. * fix: add more event triggers Trying stuff until it works. * chore: log variables I have no idea why it isn't running. * refactor: define build as dependent job Maybe this works. * fix: dots are important m( * fix: mark up as reusable workflow Was this the missing piece? * refactor: don't trigger build workflow directly Instead the idea is to reuse it in tests and deployment. * Build & Testing Artifact Workflow adjustments * Build & Testing Artifact Workflow adjustments * Fixed artifact name * fix: ls on not existing directories This is to check where the artifact is extracted. * fix: Extracting artifact to wrong path This should extract public/build into the working directory. I've also added the git checkout and PHP steps * chore: Checking where the artifact is extracted * chore: Checking where the artifact is extracted * chore: Checking where the artifact is extracted * chore: Checking where the artifact is extracted * chore: Checking where the artifact is extracted * chore: Checking where the artifact is extracted * chore: Checking where the artifact is extracted * fix: Download artifacts into correct directories * feat: Test vendor cache between workflows * feat: Workflow adjustments * feat: Create testing database in tests workflow * feat: Split build workflow between PHP and Node jobs * feat: Change job names and matrixes * chore: Change PHP build job name to match default convention * refactor: Changed workflow names to be shorter in general * feat: Added composer validation * Create dependabot.yml Defer dependency update checks to a bot. * fix: define package ecosystem We're using npm and composer. * fix: thou shall keep 'em apart Dependabot insists on having an item per package-ecosystem. --------- Signed-off-by: André Jaenisch <andre.jaenisch@posteo.de> Co-authored-by: Stephano Vogel <stevenobird@users.noreply.github.com> Co-authored-by: Stephano Vogel <stephano.vogel@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the branches diverge even further.