Port CC:T's data generators to Fabric #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump Loom and Fabric API version. - Update MixinSoundEngine - I believe the lambda is mapped differently on the latest Loom version. - Fix several deprecation warnings.
- Remove most conventional tag definitions - those are built into
Fabric now.
- Port CC:T's data generators to Fabric. This covers loot tables,
advancements/recipes and block/item tags. As with CC:T, some of our
custom recipes are not covered.
This implements everything that CC:T does aside from turtles. Other blocks could also be converted (printers, disk drives, etc...), but I've never got round to them.
SquidDev
force-pushed
the
feature/datagen
branch
from
3eff7ff
to
504e15f
Compare
|
so this just makes the resources better during development? |
|
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pretty direct port (aside from models), so should be fairly easy to maintain. Also fixes some issues in the upgrade impostor recipes where the turtle/pocket computer and upgrade item were swapped.
This doesn't include data generators for turtle/pocket computer upgrades, as that whole subsystem never made its way to Fabric, and probably needs to wait until a major MC version change.