fix windows build bug #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the extension on Windows with WSL installed, the npm 'master' branch was detected instead of 'windows_master', resulting in an error.
'The terminal process "C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe -Command rm -rf out" terminated with exit code: 1.'
By adding OS-based detection, the extension can be built correctly across all OS systems.
PS: Did not check the branching logic in .vscode/launch.json, we might be able to ditch the 'windows_master' branch altogether by adding OS-based conditions to all tasks. (Currently, the only difference is using 'rm' or 'Remove-item', which can be done inline relatively easily using only OS-based conditions)