Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation error for mod helper #347

Closed
tythewebguy opened this issue Jul 5, 2016 · 3 comments
Closed

Documentation error for mod helper #347

tythewebguy opened this issue Jul 5, 2016 · 3 comments

Comments

@tythewebguy
Copy link

The documentation under "Combination of keys" appears to be incorrect. It shows 'ctrl+s' and 'command+s' where it should be 'mod+s'.

screen shot 2016-07-05 at 9 22 45 am

@ccampbell
Copy link
Owner

Oh wow. This is very bizarre. This shows up correctly for me:

v3h1

I just made a lot of updates to Rainbow (my syntax highlighting library) so I wonder if it is some sort of strange issue there. If you disable javascript on the page does it show up correctly?

@tythewebguy
Copy link
Author

I just checked the page again and it's correct now. Weird. I also took a
look at my browser history to make sure I wasn't on some other website (I
tend to rely on Google too much), and confirmed that I was at
https://craig.is/killing/mice. So I guess it's no longer a problem.

BTW, great library! We're using it pretty heavily in an Ember project and
it's been working great.

On Tue, Jul 5, 2016 at 9:34 AM, Craig Campbell notifications@github.com
wrote:

Oh wow. This is very bizarre. This shows up correctly for me:

[image: v3h1]
https://cloud.githubusercontent.com/assets/259316/16592019/b158ad30-42ac-11e6-9f52-c7a05e80b653.png

I just made a lot of updates to Rainbow (my syntax highlighting library)
so I wonder if it is some sort of strange issue there. If you disable
javascript on the page does it show up correctly?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#347 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AB1-5tas5kHalvhyMocgLQ4F9RuOq1Wqks5qSoeegaJpZM4JFS1W
.

@ccampbell
Copy link
Owner

Thank you! Glad to hear it.

So weird. So rainbow processes the syntax highlighting using a webworker and assigns it back to the proper div using a randomly generated identifier:

https://github.com/ccampbell/rainbow/blob/3374f1322bfa01885ce7d19a7c5021336af09513/src/rainbow.js#L162

So I suppose this is technically possible if somehow both of those blocks were assigned the same identifier, but I feel like that is extremely unlikely. Going to close this out for now then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants