Fix keypin column in commercial valuation data #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrridgeway
commented
Nov 18, 2024
| sep = "-" | ||
| ), | ||
| keypin | ||
| ), |
There was a problem hiding this comment.
I could not for the life of me get ccao:pin_format_pretty to work here.
There was a problem hiding this comment.
What error were you getting? IMO it's worth using our builtins whenever possible.
added 2 commits
November 18, 2024 15:25
…ao-data/data-architecture into fix-commercial-valuation-data
wrridgeway
commented
Nov 18, 2024
| @@ -194,5 +212,6 @@ list.files( | |||
| select(all_of(sort(names(.)))) %>% | |||
| relocate(c(keypin, pins, township, year)) %>% | |||
| relocate(c(file, sheet), .after = last_col()) %>% | |||
| distinct() %>% | |||
There was a problem hiding this comment.
Oddly, there are some rows that are duplicated across all columns.
dfsnow
reviewed
Nov 26, 2024
| filter( | ||
| check.numeric(excesslandval), | ||
| !is.na(keypin), | ||
| !str_detect(keypin, "[:alpha:]"), |
There was a problem hiding this comment.
This is going to drop_any_ key PIN with an alphabetical character. Are there any cases like 13264290020000A where we don't want that to happen?
| sep = "-" | ||
| ), | ||
| keypin | ||
| ), |
There was a problem hiding this comment.
What error were you getting? IMO it's worth using our builtins whenever possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding commercial data documentation to the wiki I was trying to determine if there is a way to define primary keys for the data (I couldn't). I did, however, determine that there were some pretty bad values for
keypinin the data. We try to clean this data as little as possible, but given the importance ofkeypin, it feels prudent to make sure we don't have rows with random notes or "TOTAL PINS" askeypin.This PR reduces the size of the dataset by about 500 rows and cleans they
keypincolumn in about 1000 more.