Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new parking space CDU code to nonlivable construction #732

Merged

Conversation

wrridgeway
Copy link
Member

@wrridgeway wrridgeway commented Feb 11, 2025

Since we don't have any 'PS' CDUs yet, this code shouldn't result in any changes to our data, and doesn't:

select
	count(*)
from iasworld.oby
where user16 = 'PS'

yields 0, as does

select
	count(*)
from iasworld.comdat
where user16 = 'PS'
select
  is_parking_space,
  parking_space_flag_reason,
  is_question_garage_unit,
  is_common_area,
  'old' as source
from default.vw_pin_condo_char

union all

select
  is_parking_space,
  parking_space_flag_reason,
  is_question_garage_unit,
  is_common_area,
  'new' as source
from z_ci_add_new_parking_space_code_to_nonlivable_construction_default.vw_pin_condo_char
skim_variable source n_missing logical.mean logical.count
is_parking_space new 0 0.1685960190 FAL: 9128045, TRU: 1851028
is_parking_space old 0 0.1685960190 FAL: 9128045, TRU: 1851028
is_question_garage_unit new 0 0.0001717814 FAL: 10977187, TRU: 1886
is_question_garage_unit old 0 0.0001717814 FAL: 10977187, TRU: 1886
is_common_area new 0 0.0026499505 FAL: 10949979, TRU: 29094
is_common_area old 0 0.0026499505 FAL: 10949979, TRU: 29094
> table(check$parking_space_flag_reason, check$source)
                                      
                                           new     old
  cdu                                  1593762 1593762
  declaration percent                     4012    4012
  identified by valuations as non-unit  206278  206278
  model predicted negative value          2914    2914
  prior value                             3997    3997
  unit number                            40065   40065

@wrridgeway wrridgeway marked this pull request as ready for review February 11, 2025 20:00
@wrridgeway wrridgeway requested a review from a team as a code owner February 11, 2025 20:00
Copy link
Member

@dfsnow dfsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And hopefully they never show up. Thanks for taking care of this.

@wrridgeway wrridgeway merged commit 4c244c4 into master Feb 11, 2025
7 checks passed
@wrridgeway wrridgeway deleted the add-new-parking-space-code-to-nonlivable-construction branch February 11, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants