Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move main class to new package: jgnash.app #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msgilligan
Copy link
Contributor

This will help when/if we add support for JPMS.

@ccavanaugh
Copy link
Owner

Some of the weirdness for keeping jGnash where it's at was integration into Linux and macOS desktops and the displayed application name. This was due to Java limitations at the time. I'm currently unable to test for proper behavior on macOS.

@msgilligan
Copy link
Contributor Author

Some of the weirdness for keeping jGnash where it's at was integration into Linux and macOS desktops and the displayed application name.

Is there something preventing us from moving jGnashFx into a package like jgnash.app?

I'm currently unable to test for proper behavior on macOS.

I'm a macOS user and it's also my main development platform, so (if I decide to stick with my current plans) I should be able to help with this a little.

ccavanaugh added a commit that referenced this pull request Feb 10, 2020
…velopment with jpackage cleaner (GitHub Pull Request #88) _[msgilligan]_
@ccavanaugh
Copy link
Owner

I've been able to perform a bit of testing with OSX using a VM. It's not 100% The biggest annoyance is the java menu with jgnash.app.jGnashFx being displayed. It doesn't impair function, so I'm okay as is.

Screenshot from 2020-02-10 19-07-57

http://bekwam.blogspot.com/2015/11/mac-menus-in-javafx-app.html provides a potential workaround. I think a variation that targets OSX only is workable until JavaFX improves integration.

@msgilligan
Copy link
Contributor Author

The biggest annoyance is the java menu with jgnash.app.jGnashFx being displayed.

Take a look at NSMenuFX -- I've used it successfully in the past and it is being updated for newer Java lately (there's a 2.1.7 release that isn't listed on the site)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants