Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix other operation fail after key_update fail and rollback #81

Conversation

OuyangHang33
Copy link
Collaborator

@OuyangHang33 OuyangHang33 commented Apr 24, 2024

Ref: #7

Fix this scenario:
After responder receive the incorrect UpdateAllkeys request and send error message with S3 old key, the requester will do rollback and use S3 old key to decode message. The other operation will be passed after keys rollback.

@OuyangHang33 OuyangHang33 marked this pull request as draft April 24, 2024 01:21
@OuyangHang33 OuyangHang33 force-pushed the fix_after_rollback_other_operation_fail branch 3 times, most recently from 4e32fde to 692fba8 Compare April 24, 2024 02:01
@OuyangHang33 OuyangHang33 marked this pull request as ready for review April 24, 2024 02:04
Signed-off-by: OuyangHang33 <hank.ouyang@intel.com>
@OuyangHang33 OuyangHang33 force-pushed the fix_after_rollback_other_operation_fail branch from 692fba8 to 5a0279b Compare April 25, 2024 01:51
@jyao1 jyao1 merged commit fae2ec6 into ccc-spdm-tools:main Apr 25, 2024
52 checks passed
@OuyangHang33 OuyangHang33 deleted the fix_after_rollback_other_operation_fail branch April 28, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants