Add behavior test mode. #42

kevinlemonra · 2022-01-20T19:42:29Z

./go-stun -b -s stun.stunprotocol.org:3478
Mapping Behavior: EndpointIndependent
Filtering Behavior: AddressAndPortDependent
Normal NAT Type: Port Restricted cone NAT

ccding

Thanks for the PR. Some comments are below, but at a high level, I am not quite sure the benefit of having users specify addresses while using the default port. I know ssh and telnet commands do so, but their use cases always require an address and the address could be different for each run; having a default port can let users not type a port every time. However, stun is not the same: users can use the same address/port for all runs on a particular computer and they can always copy the port while copying the address. Can you help me understand it a little bit more?

ccding · 2022-01-20T19:53:42Z

stun/client.go

-	if c.serverAddr == "" {
-		c.SetServerAddr(DefaultServerAddr)
-	}


deleting this will make us change stun.NewClient().Discover() in

go-stun/README.md

Line 57 in 4e5e57c

nat, host, err := stun.NewClient().Discover()

to

s:= stun.NewClient().SetServerAddr("") s.Discover()

which is not very good

There is a bug need to fix.

I think we should fix this before merging the PR

Your are right, no need to change it.

stun/const.go

stun/client.go

AudriusButkevicius · 2022-01-22T01:39:54Z

stun/const.go

+type NATBehavior struct {
+	MapBhvType NATBhvType // MappingBehaviorType
+	FltBhvType NATBhvType // FilteringBehaviorType
+}


Whats up with these cryptic names? Are you paying per character?

Thanks for response. It's just some ridiculous thoughts: don't want it too long. Is it better use MType and FType?

Should I move these to a test branch? There may need much more adjust.

The type is already called NATBehaviour, why can't you just call them FilteringType and BehaviourType?

Good advice.

kevinlemonra · 2022-01-22T06:53:33Z

Just want add the behavior test mode, so remove other stuff.

kevinlemonra · 2022-01-22T07:31:20Z

Here is some test.

2022/01/22 13:52:33 Do Test1
2022/01/22 13:52:33 Send To: 106.55.201.202:3478
2022/01/22 13:52:34 Received: {packet nil: false, local: 112.97.57.166:49144, remote: 106.55.201.202:3478, changed: 106.55.201.64:8000, other: <nil>, identical: false}
2022/01/22 13:52:34 Do Test2
2022/01/22 13:52:34 Send To: 106.55.201.64:3478
2022/01/22 13:52:34 Received: {packet nil: false, local: 112.97.57.166:49144, remote: 106.55.201.64:3478, changed: 106.55.201.202:8000, other: <nil>, identical: false}
2022/01/22 13:52:34 Do Test4
2022/01/22 13:52:34 Send To: 106.55.201.64:8000
2022/01/22 13:52:34 Received: {packet nil: false, local: 112.97.57.166:49144, remote: 106.55.201.202:3478, changed: 106.55.201.202:3478, other: <nil>, identical: false}
  Mapping Behavior: EndpointIndependent
Filtering Behavior: EndpointIndependent
   Normal NAT Type: Full cone NAT


2022/01/22 13:39:58 Do Test1
2022/01/22 13:39:58 Send To: 18.191.223.12:3478
2022/01/22 13:39:58 Received: {packet nil: false, local: 112.97.57.166:38217, remote: 18.191.223.12:3478, changed: <nil>, other: 18.219.110.18:3479, identical: false}
2022/01/22 13:39:58 Do Test2
2022/01/22 13:39:58 Send To: 18.219.110.18:3478
2022/01/22 13:39:58 Received: {packet nil: false, local: 112.97.61.166:37519, remote: 18.219.110.18:3478, changed: <nil>, other: 18.191.223.12:3479, identical: false}
2022/01/22 13:39:58 Do Test3
2022/01/22 13:39:58 Send To: 18.219.110.18:3479
2022/01/22 13:39:59 Received: {packet nil: false, local: 112.97.61.166:37519, remote: 18.219.110.18:3479, changed: <nil>, other: 18.191.223.12:3478, identical: false}
2022/01/22 13:39:59 Do Test4
2022/01/22 13:39:59 Send To: 18.191.223.12:3478
2022/01/22 13:39:59 Received: {packet nil: false, local: 112.97.57.166:38217, remote: 18.219.110.18:3479, changed: <nil>, other: 18.219.110.18:3479, identical: false}
  Mapping Behavior: AddressDependent
Filtering Behavior: EndpointIndependent
   Normal NAT Type: Undefined


2022/01/22 15:02:50 Do Test1
2022/01/22 15:02:50 Send To: 106.55.201.64:3478
2022/01/22 15:02:50 Received: {packet nil: false, local: 113.87.88.208:55899, remote: 106.55.201.64:3478, changed: 106.55.201.202:8000, other: <nil>, identical: false}
2022/01/22 15:02:50 Do Test2
2022/01/22 15:02:50 Send To: 106.55.201.202:3478
2022/01/22 15:02:50 Received: {packet nil: false, local: 113.87.88.208:55899, remote: 106.55.201.202:3478, changed: 106.55.201.64:8000, other: <nil>, identical: false}
2022/01/22 15:02:50 Do Test4
2022/01/22 15:02:50 Send To: 106.55.201.64:3478
2022/01/22 15:02:59 Received: Nil
2022/01/22 15:02:59 Do Test5
2022/01/22 15:02:59 Send To: 106.55.201.64:3478
2022/01/22 15:03:09 Received: Nil
  Mapping Behavior: EndpointIndependent
Filtering Behavior: AddressAndPortDependent
   Normal NAT Type: Port Restricted cone NAT


2022/01/22 07:20:37 Send To: 111.206.174.2:3478
2022/01/22 07:20:37 Received: {packet nil: false, local: 113.87.88.208:39607, remote: 111.206.174.2:3478, changed: <nil>, other: 111.206.174.3:3479, identical: true}
Not behind a NAT.

kevinlemonra

Change to MappingType and FilteringType.

kevinlemonra · 2022-01-23T06:39:02Z

stun/const.go

+type NATBehavior struct {
+	MapBhvType NATBhvType // MappingBehaviorType
+	FltBhvType NATBhvType // FilteringBehaviorType
+}


Good advice.

Add behavior test mode. Add behavior test mode.

ccding · 2022-01-24T02:58:18Z

stun/discover.go

+	if err != nil {
+		return nil, err
+	}
+	if resp2.mappedAddr.IP() == resp1.mappedAddr.IP() &&


got the following error here

➜ go-stun git:(test) ./go-stun -b -vvv 2022/01/23 20:59:42 Do Test1 2022/01/23 20:59:42 Send To: 216.93.246.18:3478 2022/01/23 20:59:42 00000000 00 01 00 18 21 12 a4 42 b3 2c 4d cc e4 65 eb 60 |....!..B.,M..e.`| 00000010 ed 9b ca 89 80 22 00 0c 53 74 75 6e 43 6c 69 65 |....."..StunClie| 00000020 6e 74 00 00 80 28 00 04 65 f9 e8 54 |nt...(..e..T| 2022/01/23 20:59:42 00000000 01 01 00 48 21 12 a4 42 b3 2c 4d cc e4 65 eb 60 |...H!..B.,M..e.`| 00000010 ed 9b ca 89 00 01 00 08 00 01 b9 88 63 40 4c 62 |............c@Lb| 00000020 00 04 00 08 00 01 b9 84 7d e7 90 f9 00 05 00 08 |........}.......| 00000030 00 01 c4 24 6b cd bb 39 80 20 00 08 00 01 24 00 |...$k..9. ....$.| 00000040 1f 0a 61 f7 80 22 00 14 56 6f 76 69 64 61 2e 6f |..a.."..Vovida.o| 00000050 72 67 20 30 2e 39 38 2d 43 50 43 00 |rg 0.98-CPC.| 2022/01/23 20:59:42 Received: {packet nil: false, local: 62.24.197.181:1298, remote: 216.93.246.18:3478, changed: 107.205.187.57:50212, other: <nil>, identical: false} 2022/01/23 20:59:42 Do Test2 2022/01/23 20:59:42 Send To: 107.205.187.57:3478 2022/01/23 20:59:42 00000000 00 01 00 18 21 12 a4 42 4f 8d 2f a4 3c db f5 5e |....!..BO./.<..^| 00000010 69 60 0f 09 80 22 00 0c 53 74 75 6e 43 6c 69 65 |i`..."..StunClie| 00000020 6e 74 00 00 80 28 00 04 a8 8f 35 b7 |nt...(....5.| 2022/01/23 20:59:51 Received: Nil panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x110ead2] goroutine 1 [running]: github.com/ccding/go-stun/stun.(*Client).behaviorTest(0xc00011bef8, 0x117b480, 0xc000010038, 0xc0000127e0, 0x0, 0x0, 0x0) /Users/cong/go/src/github.com/ccding/go-stun/stun/discover.go:204 +0x232 github.com/ccding/go-stun/stun.(*Client).BehaviorTest(0xc000045ef8, 0x0, 0x0, 0x0) /Users/cong/go/src/github.com/ccding/go-stun/stun/client.go:120 +0xe5 main.behaviorTest(0xc000045ef8) /Users/cong/go/src/github.com/ccding/go-stun/main.go:61 +0x45 main.main() /Users/cong/go/src/github.com/ccding/go-stun/main.go:41 +0x6a5

Also local: 62.24.197.181:1298 is not my local IP address

It should be nat blocked , but will be detected in the first step.Maybe the network is not stable.

Also local: 62.24.197.181:1298 is not my local IP address

Is it better to use mapped instead of local?

ccding reviewed Jan 20, 2022

View reviewed changes

kevinlemonra requested a review from ccding January 20, 2022 21:09

kevinlemonra changed the title ~~Change default server and add default server port.~~ Change default server, add default server port and behavior test mode. Jan 20, 2022

AudriusButkevicius reviewed Jan 22, 2022

View reviewed changes

kevinlemonra force-pushed the master branch 2 times, most recently from 524123f to 6baec2b Compare January 22, 2022 06:42

kevinlemonra changed the title ~~Change default server, add default server port and behavior test mode.~~ Add behavior test mode. Jan 22, 2022

kevinlemonra force-pushed the master branch from 6baec2b to 46dd3dd Compare January 22, 2022 07:24

kevinlemonra force-pushed the master branch from 46dd3dd to 6fa1de3 Compare January 23, 2022 06:38

kevinlemonra commented Jan 23, 2022

View reviewed changes

kevinlemonra force-pushed the master branch from 6fa1de3 to e7a00ae Compare January 23, 2022 07:14

Add behavior test mode.

903a944

Add behavior test mode. Add behavior test mode.

kevinlemonra force-pushed the master branch from 333b01c to 903a944 Compare January 23, 2022 07:44

ccding reviewed Jan 24, 2022

View reviewed changes

NAT blocked detect

195ba47

kevinlemonra requested a review from ccding January 24, 2022 07:00

ccding approved these changes Jan 26, 2022

View reviewed changes

ccding merged commit 877ebaf into ccding:master Jan 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add behavior test mode. #42

Add behavior test mode. #42

kevinlemonra commented Jan 20, 2022 •

edited

Loading

ccding left a comment

ccding Jan 20, 2022

kevinlemonra Jan 20, 2022

ccding Jan 21, 2022

kevinlemonra Jan 22, 2022

AudriusButkevicius Jan 22, 2022

kevinlemonra Jan 22, 2022

kevinlemonra Jan 22, 2022

AudriusButkevicius Jan 23, 2022

kevinlemonra Jan 23, 2022

kevinlemonra commented Jan 22, 2022

kevinlemonra commented Jan 22, 2022 •

edited

Loading

kevinlemonra left a comment

kevinlemonra Jan 23, 2022

ccding Jan 24, 2022 •

edited

Loading

ccding Jan 24, 2022

kevinlemonra Jan 24, 2022

kevinlemonra Jan 24, 2022

Add behavior test mode. #42

Add behavior test mode. #42

Conversation

kevinlemonra commented Jan 20, 2022 • edited Loading

ccding left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevinlemonra commented Jan 22, 2022

kevinlemonra commented Jan 22, 2022 • edited Loading

kevinlemonra left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ccding Jan 24, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kevinlemonra commented Jan 20, 2022 •

edited

Loading

kevinlemonra commented Jan 22, 2022 •

edited

Loading

ccding Jan 24, 2022 •

edited

Loading