Add missing ordering relationships

[theosotr]

This pull request adds missing ordering relationships between Package['syslog-ng'] and its associated files.

Without those missing ordering relationships, the code is unstable because configuration should always be applied after installation of the package.

[faxm0dem]

thanks for this patch, but I want to minimize package handling anyway : there is the syslog_ng module for that. I will probably require that module at some point. Your patch fails when disabling package management also.

[smortex]

Puppet variables are immutable. $require_package was already set on line 13, and catalog compilation will fail if $manage_package is evaluated to true.

You can change the code to something like this to avoid this issue:

if $manage_package {
  # ...
  $require_package = Package[$real_package_name]
} else {
  $require_package = undef
}

But maybe selectors can help you write more concise and less complex code, something like this (all files managed by the module are managed after all packages managed by the module):

Package <| tags == 'patterndb' |> -> File <| tags == 'patterndb' |>