React: fix security warnings #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All resolved by re-resolving CRA dependencies (yarn upgrade react-scripts), though the vulnerabilities aren't actually on the live codepath.
github-actions
bot
added
dependencies
|
We are not supposed to see any vulnerabilities right? I am getting 2 vulnerabilities when running "yarn audit" |
|
I guess more got flagged since. Again, they aren't really on used codepaths. The first needs CRA to update SVGR per facebook/create-react-app#11780. The latter needs CRA to update resolve-url-loader one major version as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All resolved by re-resolving CRA dependencies (yarn upgrade react-scripts), though the vulnerabilities aren't actually on the live codepath.
Can confirm with
yarn auditthat there are no complaints now.