fix bug with float32 and float64 overflowing integers #18
Conversation
ccoVeille
commented
Sep 7, 2024
•
ccoVeille
commented
- fix: float overflow when converted to integer Fixes #14 introduced a bug with float overflow #23
- chore: add new types
- chore: split conversion into multiple files
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 2 +1
Lines 60 90 +30
=========================================
+ Hits 60 90 +30 ☔ View full report in Codecov by Sentry. |
|
I see you added a 👍 is there something missing in term of setting that prevent you to approve via the GitHub feature made for that ? |
ccoVeille
force-pushed
the
float
branch
2 times, most recently
from
e05207d to
a4b2e46
Compare
ccoVeille
changed the title
|
The scope of this PR has been totally revamped, this PR is now only about fixing the bug with floats possibly overflowing integers The PR was containing changes about having error messages, it will be addressed in another PR (here is the commit for reference e374726) |
isn't that "feat" (though personally I don't use these abbreviations) |
I'm not adding new type in that commit, I'm somehow renaming it. I hate conventional commit, but I see a lot of it on GitHub, so I was somehow poisoned. When I'm on GitHub, I use it |
zero code changes
We may add the following type later: - uintptr - string - bool
ccoVeille
force-pushed
the
float
branch
2 times, most recently
from
b72ed32 to
1ac7b33
Compare
Only uint64 and uint was working as expected Fixes #23
