Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Convert and support conversion from string and boolean #55

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

ccoVeille
Copy link
Owner

@ccoVeille ccoVeille commented Dec 14, 2024

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5639866) to head (808b8a4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          157       246   +89     
=========================================
+ Hits           157       246   +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

conversion.go Show resolved Hide resolved
conversion.go Outdated Show resolved Hide resolved
conversion.go Show resolved Hide resolved
conversion.go Outdated Show resolved Hide resolved
conversion.go Show resolved Hide resolved
@ccoVeille ccoVeille force-pushed the convert branch 4 times, most recently from 626c42f to ab09560 Compare December 15, 2024 01:15
and allow to convert from string and bool
The struct of the error is no longer exported.

It helps to provide a better documentation, even if it's a breaking change.
@ccoVeille ccoVeille changed the title Add Convert, support conversion from and to string and boolean Add Convert, support conversion from string and boolean Dec 17, 2024
@ccoVeille ccoVeille changed the title Add Convert, support conversion from string and boolean Add Convert and support conversion from string and boolean Dec 17, 2024
@ccoVeille ccoVeille marked this pull request as ready for review December 17, 2024 23:36
@ccoVeille ccoVeille merged commit 214bd73 into main Dec 17, 2024
5 checks passed
@ccoVeille ccoVeille deleted the convert branch December 17, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant