Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring the API base path in the settings #42

Merged
merged 1 commit into from
May 9, 2023

Conversation

ccremer
Copy link
Owner

@ccremer ccremer commented May 9, 2023

  • Allows setting the base path in the factory config
  • The default is/was '' (empty string), which resorts to /api/v1/... or /apis/v1/....

Checklist for PR Authors

  • Link this PR to related issues if applicable
  • This PR contains a single logical change (to build a better changelog)
  • I have cleaned up the commit history (no useless army of tiny "Update file xyz" commits)
  • PR title doesn't contain a categorization prefix like "[chore]" or "feat:" -> There are labels for that

Checklist for PR Reviewers

  • Categorize the PR by setting a good title and adding one of the release labels (see below)

    Labels that control the release
    • major: major
    • minor: minor
    • patch: patch
    • performance: patch
    • skip-release: none
    • release: Release after merge. Use together with a Label that doesn't immediately release, e.g. internal.
    • internal: none
    • documentation: none
    • tests: none
    • dependencies: none

@ccremer ccremer added the minor Increment the minor version when merged label May 9, 2023
@ccremer ccremer marked this pull request as ready for review May 9, 2023 08:39
@ccremer ccremer merged commit afe66dd into master May 9, 2023
@ccremer ccremer deleted the angular-base-path branch May 9, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant