Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pluralizer and url generator to api package #46

Merged
merged 1 commit into from
May 11, 2023
Merged

Move pluralizer and url generator to api package #46

merged 1 commit into from
May 11, 2023

Conversation

ccremer
Copy link
Owner

@ccremer ccremer commented May 11, 2023

These are utility classes that rather belong to a "util" package, but a dedicated package for that doesn't seem worth it.

Checklist for PR Authors

  • Link this PR to related issues if applicable
  • This PR contains a single logical change (to build a better changelog)
  • I have cleaned up the commit history (no useless army of tiny "Update file xyz" commits)
  • PR title doesn't contain a categorization prefix like "[chore]" or "feat:" -> There are labels for that

Checklist for PR Reviewers

  • Categorize the PR by setting a good title and adding one of the release labels (see below)

    Labels that control the release
    • major: major
    • minor: minor
    • patch: patch
    • performance: patch
    • skip-release: none
    • release: Release after merge. Use together with a Label that doesn't immediately release, e.g. internal.
    • internal: none
    • documentation: none
    • tests: none
    • dependencies: none

@ccremer ccremer added the internal Changes only affect the internal API label May 11, 2023
These are utility classes that rather belong to a util package,
but a dedicated package for that doesn't seem worth it.
@ccremer ccremer marked this pull request as ready for review May 11, 2023 20:54
@ccremer ccremer merged commit 08816d6 into master May 11, 2023
@ccremer ccremer deleted the util branch May 11, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant