Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement client with Angular's HttpClient #47

Merged
merged 2 commits into from
May 17, 2023
Merged

Implement client with Angular's HttpClient #47

merged 2 commits into from
May 17, 2023

Conversation

ccremer
Copy link
Owner

@ccremer ccremer commented May 12, 2023

  • Implements the Angular client using Angular's HttpClient instead of the default fetch implementation
  • Adds an Interceptor class that applies the token to the request headers

Checklist for PR Authors

  • Link this PR to related issues if applicable
  • This PR contains a single logical change (to build a better changelog)
  • I have cleaned up the commit history (no useless army of tiny "Update file xyz" commits)
  • PR title doesn't contain a categorization prefix like "[chore]" or "feat:" -> There are labels for that

Checklist for PR Reviewers

  • Categorize the PR by setting a good title and adding one of the release labels (see below)

    Labels that control the release
    • major: major
    • minor: minor
    • patch: patch
    • performance: patch
    • skip-release: none
    • release: Release after merge. Use together with a Label that doesn't immediately release, e.g. internal.
    • internal: none
    • documentation: none
    • tests: none
    • dependencies: none
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @ccremer/kubernetes-client-angular@0.4.0-canary.47.a27aa87.0
npm install @ccremer/kubernetes-client@0.4.0-canary.47.a27aa87.0
# or 
yarn add @ccremer/kubernetes-client-angular@0.4.0-canary.47.a27aa87.0
yarn add @ccremer/kubernetes-client@0.4.0-canary.47.a27aa87.0

@ccremer ccremer added the minor Increment the minor version when merged label May 12, 2023
@ccremer ccremer marked this pull request as ready for review May 17, 2023 06:40
@ccremer ccremer merged commit 07764dc into master May 17, 2023
@ccremer ccremer deleted the angular-http branch May 17, 2023 06:41
@ccremer ccremer linked an issue May 17, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Angular client with Angular's native HttpClient
1 participant