Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust setup.py to work on newer M3 Macs. #357

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Adjust setup.py to work on newer M3 Macs. #357

merged 3 commits into from
Nov 5, 2024

Conversation

atillack
Copy link
Member

@atillack atillack commented Nov 1, 2024

Small edit to setup.py so Python compilation on newer M3 Macs works again.

rwxayheee
rwxayheee approved these changes Nov 2, 2024
View reviewed changes
Copy link
Collaborator

@rwxayheee rwxayheee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks! I approve the PR. Thanks for the nice work

diogomart
diogomart approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@diogomart diogomart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiled on Linux on Python 3.11 and boost 1.82 👍

Thank you Andreas!

@atillack
Copy link
Member Author

atillack commented Nov 5, 2024

@rwxayheee @diogomart Thank the both of you for testing :-) Merging ...

@atillack atillack merged commit 699949c into ccsb-scripps:develop Nov 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwxayheee rwxayheee rwxayheee approved these changes

@diogomart diogomart diogomart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atillack @diogomart @rwxayheee