FormatMRC: more robust handling of extended headers.
#679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to process the extended header only if its length is equal to the number of images. Ignore extended header values if the pixel size is set to zero.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #679 +/- ##
==========================================
- Coverage 42.62% 42.61% -0.01%
==========================================
Files 182 182
Lines 15924 15932 +8
Branches 3056 3057 +1
==========================================
+ Hits 6788 6790 +2
- Misses 8510 8515 +5
- Partials 626 627 +1 |
graeme-winter
pushed a commit
that referenced
this pull request
Feb 5, 2024
For mrcfile>=1.5.0 use the indexed_extended_header. Attempt to process the extended header only if its length is equal to the number of images. Ignore extended header values if the pixel size is set to zero.
toastisme
pushed a commit
to toastisme/dxtbx
that referenced
this pull request
Jul 18, 2024
For mrcfile>=1.5.0 use the indexed_extended_header. Attempt to process the extended header only if its length is equal to the number of images. Ignore extended header values if the pixel size is set to zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mrcfile>=1.5.0(Issue reading files with an FEI2 extended header including unused space ccpem/mrcfile#50). For older versions ofmrcfilejust ignore the extended header.